Finish the "intro to popgen tutorial"#296
Open
hyanwong wants to merge 3 commits intotskit-dev:mainfrom
Open
Conversation
| ```{code-cell} | ||
| ``` | ||
| samples = ts.samples() | ||
| for sample_id, h in zip(samples, ts.haplotypes(samples=samples)): |
Member
There was a problem hiding this comment.
But looking at the code around here I am confused what you want to achieve with this loop - you only obtain pop = 3 at the end of the loop hence the metadata string below is always ADMIX.
Member
Author
There was a problem hiding this comment.
I mostly thought to take it out because .haplotypes() is inefficient, and we should be pointing people towards the efficient .variants() operator in preference, if that also works for them?
Member
|
Spotted some minor bits. |
Co-authored-by: Gregor Gorjanc <gregor.gorjanc@gmail.com>
Co-authored-by: Gregor Gorjanc <gregor.gorjanc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes good use of tskit 1.0 functions like PCA and legends on plots. Also completes the TODO in the topology counting section.