-
Notifications
You must be signed in to change notification settings - Fork 0
Replace polars with curated data-analysis packages in embeddable Python workflow #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -29,7 +29,16 @@ jobs: | |||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - name: Python Embeddable Setup Dependencies | ||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||
| .\Python\Python.exe -m pip install polars | ||||||||||||||||||||||||
| .\Python\Python.exe -m pip install \ | ||||||||||||||||||||||||
| pandas \ | ||||||||||||||||||||||||
| numpy \ | ||||||||||||||||||||||||
| matplotlib \ | ||||||||||||||||||||||||
| seaborn \ | ||||||||||||||||||||||||
| scikit-learn \ | ||||||||||||||||||||||||
| openpyxl \ | ||||||||||||||||||||||||
| xlrd \ | ||||||||||||||||||||||||
| ipykernel \ | ||||||||||||||||||||||||
| jupyterlab | ||||||||||||||||||||||||
|
Comment on lines
+32
to
+41
|
||||||||||||||||||||||||
| .\Python\Python.exe -m pip install \ | |
| pandas \ | |
| numpy \ | |
| matplotlib \ | |
| seaborn \ | |
| scikit-learn \ | |
| openpyxl \ | |
| xlrd \ | |
| ipykernel \ | |
| jupyterlab | |
| .\Python\Python.exe -m pip install pandas numpy matplotlib seaborn scikit-learn openpyxl xlrd ipykernel jupyterlab |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label 'Added Package' is singular but lists multiple packages. Consider changing to 'Added Packages' for grammatical correctness.
| - **Added Package**: pandas, numpy, matplotlib, seaborn, scikit-learn, openpyxl, xlrd, ipykernel, jupyterlab | |
| - **Added Packages**: pandas, numpy, matplotlib, seaborn, scikit-learn, openpyxl, xlrd, ipykernel, jupyterlab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package xlrd is primarily used for reading old Excel files (.xls format). Since openpyxl handles modern Excel formats (.xlsx), consider documenting why xlrd is needed, or evaluate if it's necessary given that xlrd development has been discontinued and only supports .xls files up to Excel 2003 format.