Make sure nesting arrays are compacted to avoid memory overflow#114
Open
raymondfeng wants to merge 1 commit intotj:masterfrom
raymondfeng:master
Open
Make sure nesting arrays are compacted to avoid memory overflow#114raymondfeng wants to merge 1 commit intotj:masterfrom raymondfeng:master
raymondfeng wants to merge 1 commit intotj:masterfrom
raymondfeng:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR will fix #104 in a way that is consistent with the top level array compaction.
Please note that #104 is a serious security concern as malicious input string such as
foo[0][100000000]will crash the node process.