fix: cursor jumping at the beginning

[davidediak]

#321

[danoaky-tiny]

It'd be nice to have a test for this in FormControlTest.ts. Thanks for the fix!

[davidediak]

Sure, I fixed your tests and also added a test related to my fix.
Please feel free to contribute to the tests if needed, I'm not really familiar with your internal testing lib.

[danoaky-tiny]

Ah thank you. #367 also has a fix for this failing test. Once that's merged I'll rereview

[constanzaccg]

Hi! Is there any plan to incorporate this fix soon? Thank you

[danoaky-tiny]

@davidediak This needs a merge from main. Just to do with the tests, won't need much change from you.

[davidediak]

@danoaky-tiny sure, done.

[EkimChau]

Hello davidediak,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact legal@tiny.cloud to sign the Tiny CLA agreement.

[davidediak]

@EkimChau you have my permission to use my code, given the fact that I spent time fixing the bug and did open a PR.
I have no intention of proving your company with my personal data.

[TheSpyder]

This is clearly stated in the contributing guide. We don't have an automated system for it at the moment.

tinymce-angular/CONTRIBUTING.md

Line 8 in 5bcfde8

Note that contributions will require signing of our Contributor License Agreement.

The CLA protects us, our open-source community and our customers from the distribution of unauthorised code. It's non-negotiable, sorry.

[davidediak]

Btw guys, you can copy-paste my changes and open another PR, I won't mind.
I won't give away any personal data, sorry.

[carlosmintfan]

@davidediak I‘ll use your PR if it looks good to me once I fork the Angular integration for my HugeRTE fork of TinyMCE.

[joe-baudisch]

const cursor = this._editor.selection.getBookmark(3) as any
if (cursor['start'] && cursor['start'].startsWith('text()')) {
// do nothing because the cursor initially jumps back to first line with 'text()'
// while pasting in text from outside; moving to this bookmark after set content
// creates this cursor jump which should be avoided;
// if you paste in text from inside the editor or write text by keyboard
// the cursor starts with a paragraph tag created by TMCE like
// 'p[element_index]/text()[0]'
} else {
this._editor.setContent(isNullOrUndefined(value) ? '' : value);
try {
this._editor.selection.moveToBookmark(cursor);
} catch (e) {
/* ignore */
}
}