400 errors shouldn't prevent normal transformation#76
Open
Gryzor wants to merge 3 commits intotinyeeliu:masterfrom
Open
400 errors shouldn't prevent normal transformation#76Gryzor wants to merge 3 commits intotinyeeliu:masterfrom
Gryzor wants to merge 3 commits intotinyeeliu:masterfrom
Conversation
added 3 commits
January 31, 2014 15:20
… the client to decide, otherwise REST clients passing 4xx errors (that are supposed to be retried with some change according to the documentation, lose the possible custom response because the transformation is never performed.
… latest version with fixes for KitKat.
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is up to the client to decide.
REST clients pass 4xx errors to inform certain bad requests and you’re supposed to retry those requests after you make some changes (otherwise it will fail again).
In practice, the 4xx error will come with some data too, like some custom response indicating error codes among any other imaginable thing. If you treat 400 as a regular error, then that response is never going to pass through the
transform(url, type, encoding, data, status);method inAbstractAjaxCallback.java