Delete duplicate definition of LinuxMemory#31
Open
bensymonds wants to merge 1 commit intothreez:masterfrom
Open
Delete duplicate definition of LinuxMemory#31bensymonds wants to merge 1 commit intothreez:masterfrom
LinuxMemory#31bensymonds wants to merge 1 commit intothreez:masterfrom
Conversation
I think this was added accidentally in 5c13458. It generates the following warnings in our app: ``` vmstat-2.3.1/lib/vmstat/memory.rb:54: warning: method redefined; discarding old available vmstat-2.3.1/lib/vmstat/memory.rb:54: warning: method redefined; discarding old available= vmstat-2.3.1/lib/vmstat/memory.rb:58: warning: method redefined; discarding old available_bytes vmstat-2.3.1/lib/vmstat/linux_memory.rb:9: warning: previous definition of available_bytes was here ```
Author
|
@threez Anything I can do to help get this merged? Hoping it's relatively uncontroversial and can be merged and released without much trouble 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was added accidentally in 5c13458. It generates the following warnings in our app: