use relative paths instead of absolute paths#136
Open
dbesserman wants to merge 1 commit intothoughtbot:masterfrom
Open
use relative paths instead of absolute paths#136dbesserman wants to merge 1 commit intothoughtbot:masterfrom
dbesserman wants to merge 1 commit intothoughtbot:masterfrom
Conversation
When running spec on a specific file, the absolute path is sent to the runner. This prevents us from running specs within a docker container. This commit introduces relative paths instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running specs on a specific file via
vim-rspec, the absolute path is sent to therunner. This prevents us from running those specs within a docker container.
This commit introduces relative paths instead.