kmod: Add modules useful for imx platforms#1236
Open
AnneOnciulescu wants to merge 1 commit intothesofproject:mainfrom
Open
kmod: Add modules useful for imx platforms#1236AnneOnciulescu wants to merge 1 commit intothesofproject:mainfrom
AnneOnciulescu wants to merge 1 commit intothesofproject:mainfrom
Conversation
Add snd_soc_simple_card module for insert/remove testing. Also, snd_sof_utils was missing from sof_insert.sh. Signed-off-by: Anne Onciulescu <anne.onciulescu@gmail.com>
Collaborator
|
Can one of the admins verify this patch?
|
marc-hb
reviewed
Oct 11, 2024
|
|
||
| # core SOF driver | ||
| insert_module snd_sof | ||
| insert_module snd_sof_utils |
Collaborator
There was a problem hiding this comment.
This should be at least a separate commit. Maybe even a separate PR if there's any debate about snd_soc_simple_card?
Member
There was a problem hiding this comment.
unless simple_card depends on utils ? @AnneOnciulescu pls confirm.
Collaborator
There was a problem hiding this comment.
The commit message says "Also, snd_sof_utils was missing from sof_insert.sh." which is a pretty clear sign this is a separate bug fix.
Collaborator
|
SOFCI TEST |
Collaborator
|
Unrelated to this PR and off-topic but these are NOT the "usual LNL failures" More info in (possibly unrelated too) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add snd_soc_simple_card module for insert/remove testing. Also, snd_sof_utils was missing from sof_insert.sh.