Skip to content

multiple-pause-resume.sh: fix two minor quote warnings#1026

Merged
marc-hb merged 1 commit intothesofproject:mainfrom
marc-hb:multiple-pause-quotes
Apr 17, 2023
Merged

multiple-pause-resume.sh: fix two minor quote warnings#1026
marc-hb merged 1 commit intothesofproject:mainfrom
marc-hb:multiple-pause-quotes

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 17, 2023

Now shellcheck clean before #1025

@marc-hb
multiple-pause-resume.sh: fix two minor quote warnings
04165b7 
Now shellcheck clean before thesofproject#1025

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb requested a review from fredoh9 April 17, 2023 18:36
fredoh9
fredoh9 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 17, 2023 •
edited
Loading

SOFCI TEST

cavs2.5 https://sof-ci.01.org/softestpr/PR1026/build282/devicetest/index.html has only a suspend/resume timeout

MTL https://sof-ci.01.org/softestpr/PR1026/build281/devicetest/index.html (23761) and stable2.2 have both usual suspend/resume failures but also one multiple-pause-resume failure each :-(

https://sof-ci.01.org/softestpr/PR1026/build280/devicetest/index.html?model=CML_RVP_SDW&testcase=multiple-pause-resume-5 has "sof-logger already dead" which is unrelated to this PR.

The other, MTL failure has no log (not even internally) because of some unknown CI glitch.

@marc-hb marc-hb marked this pull request as ready for review April 17, 2023 23:02
@marc-hb marc-hb requested a review from a team as a code owner April 17, 2023 23:02
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 17, 2023

Second run looks better, https://sof-ci.01.org/softestpr/PR1026/build286/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1026/build287/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1026/build288/devicetest/index.html caught an actual failure. Merging

@marc-hb marc-hb merged commit 7a74c40 into thesofproject:main Apr 17, 2023
@marc-hb marc-hb deleted the multiple-pause-quotes branch April 17, 2023 23:59
@marc-hb marc-hb mentioned this pull request Apr 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredoh9 fredoh9 fredoh9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-hb @fredoh9