ASoC: SOF: Intel: Add generic function for IPC4 delayed message handling#5521
Open
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: SOF: Intel: Add generic function for IPC4 delayed message handling#5521ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
ujfalusi wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
lyakh,
plbossart and
ranj063
as code owners
The hda_ipc4_proceed_sending() can replace the duplicated code in cnl.c, hda-ipc.c and mtl.c which handles the decision to delay a message sending due to busy DSP side. With the generic function we can also add debug prints to track message flow disruptions. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
kv2019i
reviewed
Aug 26, 2025
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Code looks ok, one funny spelling error slipped in, see inline.
| } else if (hdev->delayed_ipc_tx_msg == msg) { | ||
| struct sof_ipc4_msg *msg_data = msg->msg_data; | ||
|
|
||
| dev_dbg(sdev->dev, "Sending delayed massage: %#x|%#x", |
Collaborator
There was a problem hiding this comment.
Not sure if delayed "massage" is healthy?
bardliao
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hda_ipc4_proceed_sending() can replace the duplicated code in cnl.c, hda-ipc.c and mtl.c which handles the decision to delay a message sending due to busy DSP side.
With the generic function we can also add debug prints to track message flow disruptions.