ASoC: SOF: probes support related cleanups#3014
Merged
plbossart merged 6 commits intothesofproject:topic/sof-devfrom Jun 29, 2021
Merged
ASoC: SOF: probes support related cleanups#3014plbossart merged 6 commits intothesofproject:topic/sof-devfrom
plbossart merged 6 commits intothesofproject:topic/sof-devfrom
Conversation
ujfalusi
requested review from
RanderWang,
bardliao,
dbaluta,
juimonen,
keyonjie,
kv2019i,
lgirdwood,
libinyang,
lyakh,
plbossart and
ranj063
as code owners
kv2019i
requested changes
Jun 28, 2021
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
One minor note on a git commit message, otherwise looks great!
ujfalusi
force-pushed
the
peter/sof/pr/probes_cleanup
branch
from
ad8f03e to
3fe860d
Compare
Collaborator
Author
|
@plbossart, thank you, I'll update the PR in few minutes to remove the Fixes tag. |
Probe related messages are missing from the logging, for example the PROBE_INIT would show up as: ipc tx: 0xc0010000: unknown GLB command ipc tx succeeded: 0xc0010000: unknown GLB command Add code to handle the probe messages to have human readable output Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…ence The SND_SOC_SOF_COMPRESS is not valid Kconfig option, remove it. At the same time remove the also the declaration of the non existent sof_compressed_ops. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
sof_probe_compr_ops are not platform-specific. So move it to common compress code and export the symbol. The compilation of the common compress code is already dependent on the selection of CONFIG_SND_SOC_SOF_DEBUG_PROBES, so no need to check the Kconfig section for defining sof_probe_compr_ops again. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The probe debug functionality is implemented via compress support and it was spread across two set of files: probe.c/h compress.c/h Merge the two files into sof-probes.s/h and clean them up by removing unused struct definitions, functions. We can also move most of the functions static as they are only used internally. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
The hda-compress.c is implementing the SOF probe support for intel HDA platforms using compress API. To avoid the confusion, rename it to reflect this. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
force-pushed
the
peter/sof/pr/probes_cleanup
branch
from
3fe860d to
ae77862
Compare
Collaborator
Author
|
Changes since v2:
Changes since v1:
|
dbaluta
previously approved these changes
Jun 29, 2021
Collaborator
|
Looks good to me! Thanks @ujfalusi. |
…ai_ops The snd_soc_cdai_ops have startup and shutdown callbacks defined unlike the component callbacks where open and free is used. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Collaborator
Author
|
Hi, pushed one more patch to use correct postfix for the functions used in snd_soc_cdai_ops for startup and shutdown. Sorry for the late update but I wanted to include it to this PR and not take it via the auxbus support. |
plbossart
approved these changes
Jun 29, 2021
kv2019i
approved these changes
Jun 29, 2021
ranj063
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as requested by @plbossart, I have split out the cleanup patches regarding to the probes support from #3007
The probes conversion to SOF client depends on this series.