Conversation
Issue Details File: genciwfn.cpp - Line: 46 Incorrect Variable: nword2 Correct Variable: nword Code Before Correction k += wfn.nword2; Code After Correction k += wfn.nword;
|
Hi, I'll address this after @q-pratz-chem uploads her PR which uses GenCIWfn extensively. She has probably fixed this in the meantime. |
ok ill wait till then |
Hi, I fixed it to use the GenCIWfn as a base class for the NonSingletCI class. I will make a PR collectively for the NonSingletCI and geminal wavefunction implementation, which includes a fix for this issue as well. |
|
Hi @msricher , Since you mentioned that @q-pratz-chem PR should be merged first, could you please let me know if I should proceed with any changes on my end, or wait until her PR is merged? Happy to coordinate accordingly. Best regards, |
Issue Details
File: genciwfn.cpp - Line: 46
Incorrect Variable: nword2
Correct Variable: nword
Code Before Correction
k += wfn.nword2;
Code After Correction
k += wfn.nword;