Skip to content

feat: add customizable progress view to AsyncButton #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcHidalgo5 merged 9 commits into from
Feb 12, 2026
Merged

feat: add customizable progress view to AsyncButton #453

MarcHidalgo5 merged 9 commits into from
Feb 12, 2026

Conversation

@MarcHidalgo5
Copy link
Contributor

@MarcHidalgo5 MarcHidalgo5 commented Feb 9, 2026 •
edited
Loading

Introduce a new method asyncButtonProgressView allowing customization of the progress view displayed by AsyncButton. This change enables developers to provide a custom progress view appearance in addition to the existing loading states.

The update includes:

  • Creation of an AsyncButtonProgressViewProvider typealias and corresponding environment value.
  • Replacement of hardcoded ProgressView with a customizable progressView property in AsyncButton.
  • New view modifiers for setting custom progress view configurations.
  • Enhanced flexibility in UI design for loading states.

Introduce a new method asyncButtonProgressView allowing customization of the progress view displayed by AsyncButton. This change enables developers to provide a custom progress view appearance in addition to the existing loading states.

The update includes:

  • Creation of an AsyncButtonProgressViewProvider typealias and corresponding environment value.
  • Replacement of hardcoded ProgressView with a customizable progressView property in AsyncButton.
  • New view modifiers for setting custom progress view configurations.
  • Enhanced flexibility in UI design for loading states.

Usage example

Before (default progress view):

AsyncButton {
    try await checkSMSCodeAndPerformAuthentication()
} label: {
    smsConfirmationButtonView()
}

After (custom progress view):

AsyncButton {
    try await checkSMSCodeAndPerformAuthentication()
} label: {
    smsConfirmationButtonView()
}
.asyncButtonProgressView { _ in
    ModernCircularProgressView(tintColor: Color.BlackTextColor)
}

@MarcHidalgo5
feat: add customizable progress view to AsyncButton
ec33a57 
Introduce a new method `asyncButtonProgressView` allowing
customization of the progress view displayed by `AsyncButton`.
This change enables developers to provide a custom progress
view appearance in addition to the existing loading states.

The update includes:
- Creation of an `AsyncButtonProgressViewProvider` typealias
  and corresponding environment value.
- Replacement of hardcoded `ProgressView` with a customizable
  `progressView` property in `AsyncButton`.
- New view modifiers for setting custom progress view configurations.
- Enhanced flexibility in UI design for loading states.
piercifani
piercifani reviewed Feb 9, 2026
View reviewed changes
piercifani
piercifani reviewed Feb 9, 2026
View reviewed changes
@MarcHidalgo5
feat: add customizable progress view for AsyncButton
945c7a7 
Introduce an optional customization for the progress view in
`AsyncButton`. Implement an environment key for `asyncButtonProgressViewProvider`
to allow custom styling of the loading spinner. This change
enables developers to provide a custom loading spinner via
a closure tied to the AsyncButton, enhancing the user experience
and visual consistency with the app's theme. Default behavior
remains unchanged unless provided with a custom configuration.
@MarcHidalgo5
feat: add customizable loader to HUD view
f819238 
Allow customizing the HUD loading spinner by adding a `loader`
view builder parameter to the `hud` modifier. This enhancement
provides more flexibility in defining how loading states are
represented in the interface. The default implementation
remains with a `ProgressView`, but now users can substitute
their own loader components to better align with their design
requirements. The change affects the modifiers for both iOS
and macOS platforms, ensuring consistent customization across
the implementations.
@MarcHidalgo5
refactor: improve AsyncButton's progress view customization
d93af94 
Refactor AsyncButton in Swift to allow more flexible and customizable
loading indicators. Introduce a generic Progress view parameter to
the AsyncButton struct, replacing the fixed progress view logic with
a customizable provider approach. This change provides a new default
progress view and a progress view builder modifier, enabling users to
specify custom loading indicators more easily.

This improves code modularity and aligns the component with idiomatic
SwiftUI patterns. Simplifying the AsyncButton logic helps both maintain
and extend the component.
@MarcHidalgo5
docs: add documentation for AsyncButton components
0487a8c 
Enhance the `AsyncButton` by adding comprehensive documentation,
explaining its purpose for `async` actions and UI feedback
during loading states. The documentation specifies customization
via `.asyncButtonLoadingConfiguration` and details blocking
and inline styles. This clarity aids developers in using and
customizing the component effectively. Additionally,
simplify `EnvironmentValues` management for better modularity.
@MarcHidalgo5
perf: enhance HUDView and AsyncButton
b21f8e5 
Refactor HUDView to improve flexibility and maintainability by
renaming variables for better clarity. In HUDState, change
variable names from 's' to 'string' for better readability.

In AsyncButton, streamline performAction by changing Result
to Swift.Result for consistency. Enhance loader messages
with detailed inline and blocking configuration. Improve loading
indicators with scaling and text customization. This enables
better user feedback while maintaining interface consistency.
piercifani
piercifani reviewed Feb 10, 2026
View reviewed changes
piercifani
piercifani approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@piercifani piercifani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that change and that's it

@MarcHidalgo5
refactor: adjust AsyncButton visibility and extensions
bfbb298 
Change `DefaultAsyncButtonProgressView` from `public` to `internal`
to limit its visibility as it's primarily used internally.
Remove the `public` keyword from `AsyncButton` extensions to use
default module-wide access level, aligning with internal usage
patterns. This enhances encapsulation and reduces public API
exposure, simplifying maintenance and ensuring proper usage within
its intended scope.
@MarcHidalgo5
feat: make AsyncButton initializers public and expose default progres…
876aa82 
…s view

Modify the initializer of `AsyncButton` and `DefaultAsyncButtonProgressView`
to be public, allowing external modules to instantiate and utilize these
components. This change improves the library's extensibility and integration
capabilities for developers who need to leverage `AsyncButton` in their own
SwiftUI projects. The `public` access level for `DefaultAsyncButtonProgressView`
enables users to customize and utilize the default view for displaying progress.
@MarcHidalgo5
fix: make AsyncButton extensions public for wider access
83e9d9e 
Change the visibility of certain AsyncButton extensions from internal
to public. This allows users to access convenience initializers for
AsyncButtons with text or image labels outside of the module. This
modification improves flexibility and usability by enabling API
consumers to easily initialize buttons using strings, localized
string keys, or system images without needing to redefine these
initializers.
@MarcHidalgo5 MarcHidalgo5 merged commit fbc9d41 into develop Feb 12, 2026
3 checks passed
@MarcHidalgo5 MarcHidalgo5 deleted the async-button-custom-loading branch February 12, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piercifani piercifani piercifani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcHidalgo5 @piercifani