Fix arguments in method defifinition.#136
Open
graceful-potato wants to merge 1 commit intotextmate:masterfrom
Open
Fix arguments in method defifinition.#136graceful-potato wants to merge 1 commit intotextmate:masterfrom
graceful-potato wants to merge 1 commit intotextmate:masterfrom
Conversation
Contributor
Author
|
I can undo changes in @infininight can you please take a look? |
2c906ca to
90b5672
Compare
…r multiline arguments in method definition without parentheses. Add support for double splat operator.
90b5672 to
9b41083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, I kind of fixed #135 , but I changed some other rules that I think I shouldn't have touched. I tried not to change them and do it using repositories for specific rules, but I noticed slightly different behavior when using repositories in vscode and textmate.
Before
After
Also I added double splat operator support in parameters.