Create CLI interface for tf-cloud#283
Conversation
eddydecena
commented
Jan 20, 2021
eddydecena
commented
- Create CLI interface based on typer in top of click (docs: https://typer.tiangolo.com/)
- Create a command to get remote (something like: tfc remote)
- Create a command to run (something like: tfc run --entry-point mnist_example.py)
- Create CLI interface based on typer in top of click (docs: https://typer.tiangolo.com/) - Create command for get remote (something like: tfc remote) - Create command for run (something like: tfc run --entry-point mnist_example.py)
|
This pull request is about issue #279. |
SinaChavoshi
left a comment
SinaChavoshi
left a comment
There was a problem hiding this comment.
Hi Eddy,
Thank you for the contribution. I have three specific requests:
-
Could you move the cli.py module under cloud/src/python/tensorflow_cloud/experimental/cli - I would like to keep it under experimental until we see user feedback and utilization.
-
Please use soft dependency instead of additions to dependancy.py. Specifically you can check for installed modules or attempt to import the required module for the cli.py and raise an error with corresponding instructions for the user when user uses the cli.py module and the required dependancies do not exist.
-
[Optional - though highly recommended] Do you mind adding a short readme with instructions on how to generate / update the cli.py module for future developers / maintainers.
1. Could you move the cli.py module under cloud/src/python/tensorflow_cloud/experimental/cli - I would like to keep it under experimental until we see user feedback and utilization. 2. Please use soft dependency instead of additions to dependancy.py. Specifically you can check for installed modules or attempt to import the required module for the cli.py and raise an error with corresponding instructions for the user when user uses the cli.py module and the required dependancies do not exist. 3. [Optional - though highly recommended] Do you mind adding a short readme with instructions on how to generate / update the cli.py module for future developers / maintainers.
1. Fix link error for instalations 2. Fix link error for Typer documentation
Adding requested change
Create dependency for typer as soft dependency
|
@SinaChavoshi Let me know any other requirements |
SinaChavoshi
left a comment
SinaChavoshi
left a comment
There was a problem hiding this comment.
Thank you for the update :)
I have one follow up, seems like there are two copies of cli.py, the original is still remaining in src/python/tensorflow_cloud/core/cli.py could you remove that and only use src/python/tensorflow_cloud/experimental/cli/cli.py.
1. cli.py file was move to src/python/tensorflow_cloud/experimental/cli.py
|
@SinaChavoshi Done |
SinaChavoshi
left a comment
SinaChavoshi
left a comment
There was a problem hiding this comment.
Thank you for the PR! great work :)
|
Thank you for approving this feature, let's keep improving it. |
|
@SinaChavoshi What's going on? How can I fix that error from |
SinaChavoshi
added
ready to pull
2 participants
