This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Add option support for native NCHW input data format.#268
Open
ghostplant wants to merge 1 commit intotensorflow:masterfrom
Open
Add option support for native NCHW input data format.#268ghostplant wants to merge 1 commit intotensorflow:masterfrom
ghostplant wants to merge 1 commit intotensorflow:masterfrom
Conversation
Contributor
|
Can you clarify what this PR does? With --input_data_format, you move the transpose logic to another part of the code, but you still do the transpose. |
Author
|
@reedwm Hi, it is a good question. Because it is possible to generate the input in NCHW format directly such as dataset.from_tensor/from_generator and other kind of pre-processed data, which would be faster during training and inference in terms of performance and it also costs less GPU memory and also CPU memory since we no longer need a useless format conversion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the issue: #267
Note: If not specifying
--input_data_format=NCHWmanually, all existing logic keeps unchanged.