-
Notifications
You must be signed in to change notification settings - Fork 235
feat(syncer-service): onboard syncer-service component #3198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
77a2861 to
0d89eb4
Compare
|
@ab-ghosh - Thanks for sharing the outcome of upgrade tests. Please includes tests to make sure that sync service behaves the expected way in hub and spoke cluster. Check the possibility incorporating tests in the following one atleast for each type : locations: https://github.com/tektoncd/operator/tree/main/test Also see the possibility of incorporating unit tests. |
| // Syncer-service is enabled when: | ||
| // 1. Multi-cluster is NOT disabled (i.e., multi-cluster is enabled) | ||
| // 2. The role is Hub | ||
| func IsSyncerServiceEnabled(scheduler *v1alpha1.Scheduler) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add unit test
0d89eb4 to
4014bda
Compare
Add conditional deployment of syncer-service based on TektonConfig: - scheduler.multi-cluster-disabled: false - scheduler.multi-cluster-role: Hub Includes CRD, controllers, reconcilers for Kubernetes and OpenShift. Signed-off-by: ab-ghosh <abghosh@redhat.com>
4014bda to
fc75dd3
Compare
|
/kind feature |




Changes
This PR onboards the syncer-service component into the Tekton Operator with conditional deployment based on TektonConfig scheduler settings.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes