Task #114679 refactor: [User Plugin] - Resolved Phpcs error and code …#72
Open
Pratikshakhandagale wants to merge 3 commits intotechjoomla:masterfrom
Open
Task #114679 refactor: [User Plugin] - Resolved Phpcs error and code …#72Pratikshakhandagale wants to merge 3 commits intotechjoomla:masterfrom
Pratikshakhandagale wants to merge 3 commits intotechjoomla:masterfrom
Conversation
Pratikshakhandagale
changed the title
manojLondhe
reviewed
Dec 18, 2017
| } | ||
|
|
||
| /** | ||
| * Method to get groups list |
manojLondhe
reviewed
Dec 18, 2017
| public function post() | ||
| { | ||
| $this->plugin->setResponse( JText::_( 'PLG_API_USERS_UNSUPPORTED_METHOD_POST' )); | ||
| $this->plugin->setResponse(JText::_('PLG_API_USERS_UNSUPPORTED_METHOD_POST')); |
Member
There was a problem hiding this comment.
can you do it like
$this->plugin->err_code = 405;
$this->plugin->err_message = JText::_('PLG_API_USERS_GET_METHOD_NOT_ALLOWED_MESSAGE');
$this->plugin->setResponse(null);```
manojLondhe
reviewed
Dec 18, 2017
|
|
||
| return; | ||
| } | ||
| $this->plugin->setResponse(JText::_('PLG_API_USERS_IN_DELETE_FUNCTION_MESSAGE')); |
Member
There was a problem hiding this comment.
@coolbung @Pratikshakhandagale why did we remove delete code.?
Member
There was a problem hiding this comment.
I believe because it wasn't robust. The plugin triggers weren't firing or something.. dont remember now. But ok if we can verify and bring it back.
However the bigger problem with this resource is that it's hardwired to work with Easysocial. That needs to be fixed.
manojLondhe
requested changes
Dec 18, 2017
Member
manojLondhe
left a comment
manojLondhe
left a comment
There was a problem hiding this comment.
Refer to comments for changes needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…updated