(fect)add bucketlist edit functionality#7
Open
Twhidur-Rahman-Abid wants to merge 4 commits intotapascript:mainfrom
Open
(fect)add bucketlist edit functionality#7Twhidur-Rahman-Abid wants to merge 4 commits intotapascript:mainfrom
Twhidur-Rahman-Abid wants to merge 4 commits intotapascript:mainfrom
Conversation
add bucketlist edit functionality and add necessary css issue tapascript#1
atapas
requested changes
Nov 13, 2023
src/BucketListItem.jsx
Outdated
| {!props.item.complete && ( | ||
| <button onClick={handleIsEditable}>Edit</button> | ||
| )} | ||
| <button>Delete</button> |
Contributor
There was a problem hiding this comment.
Remove delete. This issue is only for Edit. One PR for one issue, no extra code should be added to the PR.
Author
There was a problem hiding this comment.
Dada, I have removed the delete button. After pulling this repo I styled the edit button with tailwind CSS and saved the edited text to local storage using the saveWish function from the util file.
Screenshot or example output
✅ Deploy Preview for solidbucketlist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bucketlist edit functionality and add necessary css
issue #1
Screenshot or example output