Node 0.6 compatibility#8
Open
TrevorBurnham wants to merge 3 commits intotafa:masterfrom
TrevorBurnham:node_06
Open
Node 0.6 compatibility#8TrevorBurnham wants to merge 3 commits intotafa:masterfrom TrevorBurnham:node_06
TrevorBurnham wants to merge 3 commits intotafa:masterfrom
TrevorBurnham:node_06
Conversation
Eliminates deprecation warning under Node 0.6
|
this solves issue with 0.6. |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 could you please merge this pull request, because i dont want to use trevors branch if not necessary... |
|
you can use |
|
alright, ty matjaz |
|
Perhaps less pressing, but the value of ENOENT also looks like it has changed. The value in the in node 0.6.11 is now 34 (defined on line 105 of deps/uv/include/uv.h). node-watch-tree has it specified as 2. |
|
you can't rely on error.errno. But I guess you can check error.code property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anyone who uses node-watch-tree under Node 0.6 on a directory with files in it is going to get an error
It turns out the reason is—somewhat bafflingly—that the error code for
ENOTDIRchanged from 20 to 27, so the testerr.errno == ENOTDIRin [stat.coffee[(https://github.com/tafa/node-watch-tree/blob/master/src/watchers/stat.coffee) fails. This patch changes the currenterr.errnochecks toerr.codechecks. All tests pass.Also,
require 'util'is used instead ofrequire 'sys'when running tests, since doingrequire 'sys'generates the distracting deprecation message