fix: strip lightning scheme prefix from scanned QR codes#767
Draft
fix: strip lightning scheme prefix from scanned QR codes#767
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #764
This PR fixes LNURL-pay QR code scanning failing with "Decoding error" when the QR code contains a
LIGHTNING:URI scheme prefix.Description
Some wallets and services generate LNURL QR codes with a
LIGHTNING:URI scheme prefix (per BOLT specs). The bitkit-core decoder doesn't handle these prefixes, causing the scan to fail.The app already had a
removeLightningSchemes()workaround for deep links, but it wasn't applied to the QR scanner path and didn't handle theLIGHTNING:prefix. This PR:handleScan()so all input paths benefit (QR scanner, paste, manual entry, deep links)lightning:prefix handling with case-insensitive matchingPreview
QA Notes
LIGHTNING:prefix (e.g.LIGHTNING:LNURL1DP68GURN...)LNURL1DP68GURN...)lnurl:scheme prefix