NFC: BridgeJS: Reduce retained object cleanup warning noise in BridgeJS glue#633
Open
krodak wants to merge 1 commit intoswiftwasm:mainfrom
Open
NFC: BridgeJS: Reduce retained object cleanup warning noise in BridgeJS glue#633krodak wants to merge 1 commit intoswiftwasm:mainfrom
krodak wants to merge 1 commit intoswiftwasm:mainfrom
Conversation
Member
kateinoigakukun
left a comment
kateinoigakukun
left a comment
There was a problem hiding this comment.
I guess we actually don't need the release because the ownership of the object id is taken by JSObject when popped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
BridgeJS-generated cleanup currently reads retained object IDs with
swift.memory.getObject(id)before callingswift.memory.release(id). In cases where an ID is already invalid at cleanup time, that pre-read throws first and produces warning noise even though cleanup is already intended to be best-effort.This change updates
JSGlueGento emit a shared retained-object cleanup helper that callsswift.memory.release(id)directly insidetry/catch, and removes thegetObjectpre-check from generated cleanup blocks.