Skip to content

Prevent cross-module inlining of remaining @_extern(wasm) functions #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 1 commit into from
Feb 13, 2026
Merged

Prevent cross-module inlining of remaining @_extern(wasm) functions #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 45 additions & 16 deletions Sources/JavaScriptKit/BridgeJSIntrinsics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,23 @@ import _CJavaScriptKit

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_throw")
@_spi(BridgeJS) public func _swift_js_throw(_ id: Int32)
private func _swift_js_throw_extern(_ id: Int32)
#else
private func _swift_js_throw_extern(_ id: Int32) {
_onlyAvailableOnWasm()
}
#endif

/// Throws a JavaScript exception from Swift code.
///
/// This function is called by the BridgeJS code generator when a Swift function throws
/// an error. The exception object is retained and stored for later retrieval by the
/// JavaScript-side runtime code.
///
/// - Parameter id: The ID of the JavaScript exception object to throw
@_spi(BridgeJS) public func _swift_js_throw(_ id: Int32) {
_onlyAvailableOnWasm()
@_spi(BridgeJS) @inline(never) public func _swift_js_throw(_ id: Int32) {
_swift_js_throw_extern(id)
}
#endif

/// Retrieves and clears any pending JavaScript exception.
///
Expand Down Expand Up @@ -702,31 +706,44 @@ where Self: RawRepresentable, RawValue: _BridgedSwiftTypeLoweredIntoSingleWasmCo

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_init_memory")
@_spi(BridgeJS) public func _swift_js_init_memory(_ sourceId: Int32, _ ptr: UnsafeMutablePointer<UInt8>)
private func _swift_js_init_memory_extern(_ sourceId: Int32, _ ptr: UnsafeMutablePointer<UInt8>)
#else
@_spi(BridgeJS) public func _swift_js_init_memory(_ sourceId: Int32, _ ptr: UnsafeMutablePointer<UInt8>) {
private func _swift_js_init_memory_extern(_ sourceId: Int32, _ ptr: UnsafeMutablePointer<UInt8>) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_init_memory(_ sourceId: Int32, _ ptr: UnsafeMutablePointer<UInt8>)
{
_swift_js_init_memory_extern(sourceId, ptr)
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_push_string")
@_spi(BridgeJS) public func _swift_js_push_string(_ ptr: UnsafePointer<UInt8>?, _ len: Int32)
private func _swift_js_push_string_extern(_ ptr: UnsafePointer<UInt8>?, _ len: Int32)
#else
@_spi(BridgeJS) public func _swift_js_push_string(_ ptr: UnsafePointer<UInt8>?, _ len: Int32) {
private func _swift_js_push_string_extern(_ ptr: UnsafePointer<UInt8>?, _ len: Int32) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_push_string(_ ptr: UnsafePointer<UInt8>?, _ len: Int32) {
_swift_js_push_string_extern(ptr, len)
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_push_i32")
@_spi(BridgeJS) public func _swift_js_push_i32(_ value: Int32)
private func _swift_js_push_i32_extern(_ value: Int32)
#else
@_spi(BridgeJS) public func _swift_js_push_i32(_ value: Int32) {
private func _swift_js_push_i32_extern(_ value: Int32) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_push_i32(_ value: Int32) {
_swift_js_push_i32_extern(value)
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_push_f32")
private func _swift_js_push_f32_extern(_ value: Float32)
Expand Down Expand Up @@ -755,13 +772,17 @@ private func _swift_js_push_f64_extern(_ value: Float64) {

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_pop_i32")
@_spi(BridgeJS) public func _swift_js_pop_i32() -> Int32
private func _swift_js_pop_i32_extern() -> Int32
#else
@_spi(BridgeJS) public func _swift_js_pop_i32() -> Int32 {
private func _swift_js_pop_i32_extern() -> Int32 {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_pop_i32() -> Int32 {
_swift_js_pop_i32_extern()
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_pop_f32")
private func _swift_js_pop_f32_extern() -> Float32
Expand Down Expand Up @@ -792,13 +813,17 @@ private func _swift_js_pop_f64_extern() -> Float64 {

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_struct_cleanup")
@_spi(BridgeJS) public func _swift_js_struct_cleanup(_ cleanupId: Int32)
private func _swift_js_struct_cleanup_extern(_ cleanupId: Int32)
#else
@_spi(BridgeJS) public func _swift_js_struct_cleanup(_ cleanupId: Int32) {
private func _swift_js_struct_cleanup_extern(_ cleanupId: Int32) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_struct_cleanup(_ cleanupId: Int32) {
_swift_js_struct_cleanup_extern(cleanupId)
}

// MARK: Wasm externs used by type lowering/lifting

#if arch(wasm32)
Expand Down Expand Up @@ -986,13 +1011,17 @@ func _swift_js_return_optional_double(_ isSome: Int32, _ value: Float64) {

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_push_pointer")
@_spi(BridgeJS) public func _swift_js_push_pointer(_ pointer: UnsafeMutableRawPointer)
private func _swift_js_push_pointer_extern(_ pointer: UnsafeMutableRawPointer)
#else
@_spi(BridgeJS) public func _swift_js_push_pointer(_ pointer: UnsafeMutableRawPointer) {
private func _swift_js_push_pointer_extern(_ pointer: UnsafeMutableRawPointer) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_push_pointer(_ pointer: UnsafeMutableRawPointer) {
_swift_js_push_pointer_extern(pointer)
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_pop_pointer")
private func _swift_js_pop_pointer_extern() -> UnsafeMutableRawPointer
Expand Down