Benchmarks: Prevent cross-module inlining of f32/f64 @_extern(wasm) functions#628
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Feb 12, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Feb 12, 2026
Member
kateinoigakukun
left a comment
There was a problem hiding this comment.
I'll find a time to fix the root cause in the compiler side...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Applies
@inline(never)wrappers to_swift_js_push_f32,_swift_js_push_f64,_swift_js_pop_f32, and_swift_js_pop_f64to prevent a Swift 6.3-dev compiler bug where cross-module inlining of@_extern(wasm, module: "bjs", ...)functions causes the Wasm module name to be lost ("bjs" becomes "env"), resulting in link failures when building external packages that depend on JavaScriptKit.This follows the same pattern already used for
_swift_js_pop_pointer.Issue
All four f32/f64 functions are affected:
_swift_js_push_f32,_swift_js_push_f64,_swift_js_pop_f32,_swift_js_pop_f64.Why CI doesn't catch this
CI runs
make unittestandswift test --package-path Plugins/BridgeJS, both of which compile within the same package. The bug only manifests when a separate SwiftPM package depends on JavaScriptKit in release mode, triggering cross-module inlining.Reproduction