NFC: BridgeJS: Simplify liftExpression by using no-arg bridgeJSLiftParameter() for enums and protocols#623
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Feb 12, 2026
Conversation
krodak
force-pushed
the
kr/bridgejs-lift-simplification
branch
from
5676866 to
7829ad2
Compare
…iftParameter() intrinsics
krodak
force-pushed
the
kr/bridgejs-lift-simplification
branch
from
7829ad2 to
8970445
Compare
kateinoigakukun
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Collapses the
.swiftProtocol,.caseEnum,.associatedValueEnum, and.rawValueEnumcases inStackCodegen.liftExpression(for:)into the default path that uses the no-argbridgeJSLiftParameter()form.The runtime (
BridgeJSIntrinsics.swift) already defines no-arg overloads for all these types that pop from the WASM stack internally:_BridgedSwiftProtocolWrapper.bridgeJSLiftParameter()- pops i32_BridgedSwiftCaseEnum.bridgeJSLiftParameter()- pops i32_BridgedSwiftAssociatedValueEnum.bridgeJSLiftParameter()- pops i32_BridgedSwiftRawValueEnum.bridgeJSLiftParameter()- delegates to RawValueThe codegen was redundantly doing the pop externally and passing it as an argument. This removes that duplication, making the codegen simpler and consistent with how all other types are handled.