NFC: BridgeJS: Delegate nested container codegen to generic runtime conformances#619
Merged
kateinoigakukun merged 1 commit intoswiftwasm:mainfrom Feb 12, 2026
Conversation
krodak
force-pushed
the
kr/container-codegen-simplification
branch
from
f2de436 to
38af37b
Compare
krodak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to simplify codegen for nested container types (
[[Int]],[String: [Double]], etc.) by delegating to existing generic runtime conformances (Array: _BridgedSwiftStackType,Dictionary: _BridgedSwiftStackType) instead of generating inline for-loops in Swift thunks.Previously, when the element type of an array (or value type of a dictionary) was itself an array or dictionary, the codegen emitted inline loops that manually iterated and pushed/popped each element. The runtime already has generic conformances that do exactly this -
Array<Element>.bridgeJSLiftParameter()and.bridgeJSLowerReturn()handle recursion through the genericElement: _BridgedSwiftStackTypeconstraint. This PR routes those cases through the generic conformance path instead.