Skip to content

Competitive Coding-1 Done#1321

Open
ManishaRana1195 wants to merge 1 commit intosuper30admin:masterfrom
ManishaRana1195:master
Open

Competitive Coding-1 Done#1321
ManishaRana1195 wants to merge 1 commit intosuper30admin:masterfrom
ManishaRana1195:master

Conversation

@ManishaRana1195
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The BinarySearch.java solution is well-implemented and correctly solves the problem.
  • The MinHeap.java implementation is comprehensive and covers all necessary operations.
  • Code is generally clean and follows good practices.

Areas for Improvement:

  • In BinarySearch.java, consider using the difference approach (like in the reference solution) for potentially better clarity.
  • In MinHeap.java:
    • Fix the heapifyUp method to use size instead of size-1.
    • Correct getRightChild to return 2 * parentIndex + 2.
    • Consider making MAX_SIZE configurable rather than hardcoded.
  • Add comments to explain the logic in MinHeap.java more thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants