Skip to content

Completed CP-1#1319

Open
rbhargav0104 wants to merge 1 commit intosuper30admin:masterfrom
rbhargav0104:master
Open

Completed CP-1#1319
rbhargav0104 wants to merge 1 commit intosuper30admin:masterfrom
rbhargav0104:master

Conversation

@rbhargav0104
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Problem1.cpp:

    • Strengths: The binary search approach is a good choice for this problem.
    • Areas for Improvement: The logic for determining the missing number is incorrect. Consider comparing the difference between the element and its index, as in the reference solution. Also, add comments to explain the logic.
  • Problem2.cpp:

    • Strengths: The structure of the minHeap class is clear, and the methods are appropriately named.
    • Areas for Improvement: The heapify-up and heapify-down logic is incorrect. Review the correct implementation of these operations. The extractMin method should use h.back() instead of h.push_back(). Add comments to explain the logic and ensure correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants