update!: modified run and txn align with Rust implementation#40
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Sabi framework's API to align with the Rust implementation by moving core execution and transaction methods from DataHub to the Sabi class, while merging postCommit functionality into the commit method.
Key changes:
- Moved
DataHub#runandDataHub#txnmethods toSabi.runandSabi.txnas static methods - Moved
DataHub.FailToCastDataHuberror record toSabi.FailToCastDataHub - Integrated
postCommitfunctionality directly into thecommitmethod flow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/github/sttk/sabi/Sabi.java | Added static run and txn methods and FailToCastDataHub record |
| src/main/java/com/github/sttk/sabi/DataHub.java | Removed run, txn methods and FailToCastDataHub record; added package-private lifecycle methods |
| src/main/java/com/github/sttk/sabi/internal/DataHubInner.java | Merged postCommit functionality into commit method |
| src/test/java/com/github/sttk/sabi/internal/DataHubInnerTest.java | Updated test expectations to reflect merged commit/postCommit behavior |
| src/test/java/com/github/sttk/sabi/internal/DataAccTest.java | Updated test calls to use new static Sabi.run and Sabi.txn methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modified APIs align with Rust implementation.
DataHub#runtoSabi.runDataHub#txntoSabi.txn.Data.FailToCastDataHubtoSabi.FailToCastDataHub.DataHub#postCommitintoDataHub#commit.