Fix for issue #188 where inGroup functionality <AuthenticatedRoute /> component is not working. #193
Open
makanti wants to merge 6 commits intostormpath:masterfrom
Open
Fix for issue #188 where inGroup functionality <AuthenticatedRoute /> component is not working. #193makanti wants to merge 6 commits intostormpath:masterfrom
makanti wants to merge 6 commits intostormpath:masterfrom
Conversation
added 6 commits
March 3, 2017 17:28
* Tranform groups object into an array of groupnames (backwards compatible with the case were groups was an associative array. * Set scope to be a clean new object rather than a clone of groups object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #188 where inGroup functionality component is not working.
This is tweaking @Tweety-FER solution presented in #189 which fixed the issue of group membership resolver but it didn't fix the issue I had were with inGroup was not working as expected.
Looking into the code below, the issue lied in the fact that
(wordMatch in scope)statement used in line 464 would always return false. "in" operator in a statement like this will try to find if the specified property is in the specified object or it will look at array's index rather than the array values (which happens in this case). 'indexOf' should be used in this case.