Open
Conversation
Member
|
Thanks @Tweety-FER , I can confirm that I can now set those handlers. I did notice an inconsistency that we should handle. In our docs we say that the handlers can be used to pass a different error back, but that's not true in this PR, it just passes back the original error because it's bound. I'm referring to this example in docs/api.md: class LoginPage extends React.Component {
onFormSubmit(e, next) {
// e.data will contain the data mapped from your form.
console.log("Form submitted", e.data);
// To return an error message, call next() as:
// next(new Error('Something in the form is wrong.'));
// Or if you want to change the data being sent, call it as:
// next(null, { myNewData: '123' });
// If you call next without any arguments,
// it will simply proceed processing the form.
next();
}
render() {
return <LoginForm onSubmit={this.onFormSubmit.bind(this)} />;
}
} |
Author
|
@robertjd Right you are! Changed the behaviour to use the passed error if it exists, otherwise it uses the old error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
onSubmitErrorandonSubmitSuccesshandlers to theResetPasswordFormand theChangePasswordForm.Fixes #168