You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Update the async library to 2.1.x and update the code and tests to reflect this.
The most important changes are that some methods that previously took next functions and callbacks that only had an arity of one now have an arity of 2. For example, filter can now be called as:
Thanks @Tweety-FER ! I've created a new 1.0.0 branch, and changed this PR to use that branch as the base. Let's start making any breaking change PRs into that branch, with the eventual goal to release a next major version.
I've tried running the express-stormpath tests while linked to these SDK changes, and most of the tests are failing. Can you take a look at the cause? I'd like to ensure that we've captured all places in this SDK where we need to update our async calls, and the express-stormpath tests are a good way to find places we don't have covered in the SDK tests
@robertjd Thanks for pointing that out. Updated the example in this repo and fiddled with the express lib to see what's going on. After pointing the dep at this branch and fixing a couple of lines of code in the express lib, the errors apparently went away. Is it the same for you? It's this PR: stormpath/express-stormpath#546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
asynclibrary to2.1.xand update the code and tests to reflect this.The most important changes are that some methods that previously took
nextfunctions andcallbacks that only had an arity of one now have an arity of 2. For example,filtercan now be called as:The following methods (method aliases given in brackets) are affected:
filter(select)rejectdetectsome(any)every(all)Fixes #569
Makes these PRs redundant: