This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Remove givenName and surname restrictions to registration data model#512
Open
typerandom wants to merge 2 commits intomasterfrom
Open
Remove givenName and surname restrictions to registration data model#512typerandom wants to merge 2 commits intomasterfrom
typerandom wants to merge 2 commits intomasterfrom
Conversation
typerandom
force-pushed
the
feature-registration-account-model
branch
from
174e449 to
ae6c1a3
Compare
robertjd
force-pushed
the
feature-registration-account-model
branch
from
ae6c1a3 to
77898aa
Compare
Member
|
@typerandom FYI that I've rebased this one against master. This one will need a lot of work on the registration controller tests. I pushed one small fix that fixed some of the failing tests. I'm testing while linked to stormpath/stormpath-node-config#61 |
typerandom
force-pushed
the
feature-registration-account-model
branch
from
77898aa to
ae6c1a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes givenName and surname restrictions on the registration data model.
Important
This depends on the PR stormpath/stormpath-node-config#61 before it can be merged.
How to verify
Verify that once the application is started the
web.register.form.fieldsconfiguration (https://github.com/stormpath/express-stormpath/blob/master/lib/config.yml#L65) reflects the account schema of your default directory.Fixes stormpath/stormpath-sdk-node#526