fix: get project compiled on msvc and clang#7
Open
FelixPetriconi wants to merge 2 commits intostlab:mainfrom
Open
fix: get project compiled on msvc and clang#7FelixPetriconi wants to merge 2 commits intostlab:mainfrom
FelixPetriconi wants to merge 2 commits intostlab:mainfrom
Conversation
Member
FelixPetriconi
commented
Nov 4, 2025
FelixPetriconi
commented
- silence shadowing because that happens a lot in future.hpp
- mark variables as maybe_unused because msvc complains in unused case of constexpr branch
- enable __cplusplus makro for msvc because it is used inside the future library but not enabled by default
* silence shadowing because that happens a lot in future.hpp * mark variables as maybe_unused because msvc complains in unused case of constexpr branch * enable __cplusplus makro for msvc because it is used inside the future library but not enabled by default
version fails to compile with CMake 4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.