Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 97.73% 94.97% -2.77%
==========================================
Files 16 19 +3
Lines 1281 2048 +767
==========================================
+ Hits 1252 1945 +693
- Misses 29 103 +74
Continue to review full report at Codecov.
|
Member
|
@jgabry is this still work in progress? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 95.29% 94.97% -0.33%
==========================================
Files 19 19
Lines 2021 2048 +27
==========================================
+ Hits 1926 1945 +19
- Misses 95 103 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces a
subset()method for"psis"objects. This is useful if you want to drop some of the contents of a"psis"object without breaking it. For example, bayesplot has an option for this forppc_loo_intervals()(https://mc-stan.org/bayesplot/reference/PPC-loo.html?q=subset#arguments) implemented via an internal function but it would be good if loo provided this functionality and bayesplot can call it.