Open
Conversation
This is a follow up to #205. In that PR we started pushing our images to quay.io/rhacs-eng/fact alongside the ones we pushed to quay.io/stackrox-io/fact to match the patterns on other stackrox repos. However, the implementation was a bit hasty and I wasn't very happy with how the code for building and using the different image names end up. The changes are pretty minor, but I think they add clarity to what is being used at each step of the CI jobs, which in turn makes it easier to figure out what we are building at each point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #205. In that PR we started pushing our images to quay.io/rhacs-eng/fact alongside the ones we pushed to quay.io/stackrox-io/fact to match the patterns on other stackrox repos. However, the implementation was a bit hasty and I wasn't very happy with how the code for building and using the different image names end up.
The changes are pretty minor, but I think they add clarity to what is being used at each step of the CI jobs, which in turn makes it easier to figure out what we are building at each point.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed