feat: variable event length#179
Draft
Molter73 wants to merge 1 commit intomauro/feat/better-path-handlingfrom
Draft
feat: variable event length#179Molter73 wants to merge 1 commit intomauro/feat/better-path-handlingfrom
Molter73 wants to merge 1 commit intomauro/feat/better-path-handlingfrom
Conversation
Molter73
force-pushed
the
mauro/feat/variable-event-length
branch
2 times, most recently
from
5a8d190 to
22145c5
Compare
Change from a fixed type for events from BPF to a variable length one. This is done by using a helper map in which we can write all the information for a given event, then submit it to the ringbuffer with the bpf_ringbuf_output helper. On the userspace, we get a RingBufItem which can be treated as a slice of bytes we can split to retrieve fields one by one. This change needs to be properly tested for performance, we should use a lot less space for each event in the ringbuffer but serializing and deserializing each event might require more CPU. TODO: Document the format for the serialized event in the ringbuffer.
Molter73
force-pushed
the
mauro/feat/variable-event-length
branch
from
22145c5 to
1aa332f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change from a fixed type for events from BPF to a variable length one. This is done by using a helper map in which we can write all the information for a given event, then submit it to the ringbuffer with the bpf_ringbuf_output helper.
On the userspace, we get a RingBufItem which can be treated as a slice of bytes we can split to retrieve fields one by one.
This change needs to be properly tested for performance, we should use a lot less space for each event in the ringbuffer but serializing and deserializing each event might require more CPU.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough.