feat: Re-implement CSV download functionality and fix test failures#52
Merged
jeffreyaven merged 4 commits intomainfrom Jun 12, 2025
Merged
feat: Re-implement CSV download functionality and fix test failures#52jeffreyaven merged 4 commits intomainfrom
jeffreyaven merged 4 commits intomainfrom
Conversation
Add --csv-download argument to %%stackql cell magic command that enables CSV download links for query results with comprehensive test coverage. ## Changes - Add --csv-download argument to both local and server magic classes - Implement CSV generation using pandas DataFrame.to_csv() - Create HTML download links using base64-encoded data URIs - Add styled download buttons with error handling - Feature only works when --no-display is not set (default behavior) - Add comprehensive tests for both local and server modes covering: * CSV download functionality * --no-display precedence behavior * HTML generation and base64 encoding * Error handling for CSV generation failures - Fix test mocking to target IPython.display directly instead of module attributes Resolves #18 Co-authored-by: jeffreyaven <jeffreyaven@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --csv-download argument to %%stackql cell magic command that enables CSV download links for query results with comprehensive test coverage.
Changes
Resolves #18