Conversation
Techassi
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
YamlSchematrait and thestackable-sharedcrate as thesharedmodule (#883).preferredAddressTypefield to ListenerClass CRD (#885).cluster.local) can now be configured in the individualoperators via the ENV variable
KUBERNETES_CLUSTER_DOMAINor resolved automatically by parsingthe
/etc/resolve.conffile. This requires usinginitialize_operatorinstead ofcreate_clientin the
main.rsof the individual operators (#893).Changed
CustomResourceExttrait is now re-exported from thestackable-sharedcrate. Thetrait functions use the same parameters but return a different error type (#883).
KeyValuePairs(as well asLabels/Annotationsvia it) is now backed by aBTreeMaprather than a
BTreeSet(#888).Derefimpl now returns aBTreeMapinstead.iter()now clones the values.Fixed
KeyValuePairs::insert(as well asLabels::/Annotations::via it) now overwritesthe old value if the key already exists. Previously,
iter()would return both values inlexicographical order (causing further conversions like
Into<BTreeMap>to prefer the maximumvalue) (#888).
Removed
CustomResourceExttrait doesn't provide agenerate_yaml_schemafunction anymore. Instead, use the high-level functions to write the schema to a file, write it to stdout or
use it as a
String(#883).