Draft
Conversation
NickLarsenNZ
reviewed
Sep 9, 2024
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Member
|
Re: the hadolint failure, I stumbled across this today: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/ Maybe we need to update the syntax for the Dockerfile for hadolint to accept the heredoc? Although, there is already an issue for hadolint: hadolint/hadolint#806 |
Member
Author
|
Converted to draft again, since:
|
| "java-devel": "11", | ||
| "async_profiler": "2.9", | ||
| "phoenix": "5.3.0-4afe457", | ||
| "phoenix": "5.3.0-ca21a87dd6", |
Member
There was a problem hiding this comment.
Can we add a comment next to this to show where it comes from?
Also, common short-hash is 7 characters long (unless there is a new recommendation to avoid collisions)?
Suggested change
| "phoenix": "5.3.0-ca21a87dd6", | |
| "phoenix": "5.3.0-ca21a87", # This is currently manually built and uploaded to Nexus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #816
Relevant comment: #816 (comment)
Images are building successfully: https://github.com/stackabletech/docker-images/actions/runs/10664458546
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.