Add defensive class validation during deserialization#85
Open
yannaingtun wants to merge 1 commit intosquirrel-sql-client:masterfrom
Open
Add defensive class validation during deserialization#85yannaingtun wants to merge 1 commit intosquirrel-sql-client:masterfrom
yannaingtun wants to merge 1 commit intosquirrel-sql-client:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a defensive safeguard to the deserialization logic in Utilities.cloneObject().
Previously, the custom ObjectInputStream.resolveClass() method loaded classes using Class.forName() without validating that the resolved class matched the expected object type. If untrusted or malformed serialized data were ever passed to this code path, this could allow unexpected classes to be resolved during deserialization.
The updated implementation verifies that the resolved class is compatible with the original object’s class and rejects incompatible classes early. This keeps the existing behavior for valid use cases while adding an extra layer of safety.