fix for echo_stdout_stderr attribute#70
Open
jojoyess wants to merge 2 commits intospyoungtech:mainfrom
Open
Conversation
Contributor
jojoyess
commented
May 23, 2025
- The echo_stdout_stderr attribute had no effect on the Multiline element when reroute_stdout AND reroute_stderr were True, which is the case for the default Output element.
- Everything got redirected to the Multiline element without echoing the text to the console.
- These changes do not change the behavior when only reroute_stdout OR only reroute_stderr is True.
- It now checks if the Window has the _original_stdout / _original_stderr attribute and then writes the text to it when echo_stdout_stderr is True.
doenicke
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.