Feature: restore uncompleted input on screen rotation#313
Feature: restore uncompleted input on screen rotation#313alexcustos wants to merge 2 commits intosplitwise:masterfrom
Conversation
|
I like this improvement, but you should use the |
|
I have been trying it at the first place, but it looks like onRestoreInstanceState restores the plain String, there are no Spans in it. I dug into it a bit more, the TokenCompleteTextView.SavedState is not involved in save/restore process at all, so it maybe a point. |
|
I guess I was thinking to try to fins the uncompleted text during the save process where you should still have the spans available. |
|
Good idea I will try to implement it... may be at weekends. |
bdb918d to
6bc7cd4
Compare
|
@alexcustos @mgod Any plans to merge this PR? |
|
Not at the moment. The general approach here is pretty good, but we probably need to move to the opposite check - instead of adding sentinels to keep track of regular text, we probably need to keep track of text ranges for each token and manually re-attach the token spans during restore instead of using the normal add token calls. The current implementation hard-codes a particular tokenizer implementation and also my original code using |
No description provided.