[WIP] Allowing Multiple Factory Instantiation#194
Open
mmelograno wants to merge 45 commits intomasterfrom
Open
[WIP] Allowing Multiple Factory Instantiation#194mmelograno wants to merge 45 commits intomasterfrom
mmelograno wants to merge 45 commits intomasterfrom
Conversation
…into task/DiLogger
Task/di logger
…into task/multipleFactory
Update License Year
…into task/multipleFactory
Task/tracker component
…into task/multipleFactory
replaced Di in favor of Context
…into task/multipleFactory
replaced setMethods and doc
…into task/multipleFactory
|
SonarQube Quality Gate
|
gthea
previously approved these changes
Jan 20, 2023
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
forwarding predis options directly without wrapping it
…into task/multipleFactory
Task/flagsetsinto mf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP SDK
What did you accomplish?
cachefrom Di.ImpressionCache,EventsCache,SplitCacheandSegmentCache.ClientandManager.contextforEvaluatorto be used inSegmentMatcher.Splitterfrom Di and made it static.Dicomponent was replaced in favor ofContextHow do we test the changes introduced in this PR?
Extra Notes