feat: Add user-friendly error handling for unsupported block types (Fixes #87)#128
Open
kallal79 wants to merge 1 commit intosplitbee:masterfrom
Open
feat: Add user-friendly error handling for unsupported block types (Fixes #87)#128kallal79 wants to merge 1 commit intosplitbee:masterfrom
kallal79 wants to merge 1 commit intosplitbee:masterfrom
Conversation
- Implements solution for issue splitbee#87: Return errors when importing unsupported content types - Adds UnsupportedBlockError component with clear, actionable error messages - Supports databases, checkboxes, table of contents, and other unsupported blocks - Provides helpful suggestions (remove block or use react-notion-x) - Maintains backward compatibility with showUnsupportedBlockErrors prop (default: true) - Includes optional onUnsupportedBlock callback for custom error handling - Adds comprehensive CSS styling with dark mode support - Replaces silent failures with user-friendly error messages Breaking change: None - error display is enabled by default but can be disabled Fixes: splitbee#87
Author
Author
|
Could someone from the team kindly review and approve the pending workflows when possible? Would be great to get this merged. Thanks! ( @cball , @dvdsgl , @thmsmlr , @transitive-bullshit ).. |
Author
|
HI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements user-friendly error handling for unsupported block types in react-notion, addressing Issue #87.
Problem Solved
Previously, when unsupported content types (databases, checkboxes, table of contents) were encountered, the library would silently fail to render content, leaving users confused.
Solution Implemented
Files Changed
Fixes #87