fix port listing crash when a port is removed during the listing#147
Open
Houston4444 wants to merge 1 commit intospatialaudio:masterfrom
Open
fix port listing crash when a port is removed during the listing#147Houston4444 wants to merge 1 commit intospatialaudio:masterfrom
Houston4444 wants to merge 1 commit intospatialaudio:masterfrom
Conversation
Member
|
Thanks for this PR! I'm wondering though: you are fixing two things (NULL pointer and unexpected port type), but your description only mentions one problem (AFAIU). If both fixes are necessary, please describe the second problem. Maybe one of the problems will go away when #146 is fixed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I meet this crash several times with the method Client.get_ports() :
The port name is not always the same. It happens when I switch from a (ray) session to another, many clients are quitting. It is very very probable that port has been destroyed during listing.
This patch fixes the problem with the choice to not raise any exception in this case, if port has gone, it must not be listed.