Fix exception thrown using the Symfony profiler for Messenger workers #24#25
Open
adrienbrault wants to merge 1 commit intomainfrom
Open
Fix exception thrown using the Symfony profiler for Messenger workers #24#25adrienbrault wants to merge 1 commit intomainfrom
adrienbrault wants to merge 1 commit intomainfrom
Conversation
…24 Fixes #24 Fix exception thrown using the Symfony profiler for Messenger workers * Replace backslashes with regular slashes in the transaction name in `src/EventListener/MessengerProfilerListener.php` * Use `str_replace('\\', '/', \get_class($event->getEnvelope()->getMessage()))` * Replace backslashes with regular slashes in the transaction name in `src/Messenger/ProfilerMiddleware.php` * Use `str_replace('\\', '/', \get_class($envelope->getMessage()))` * Ensure the transaction name is used in the URI with regular slashes in `src/Profiler/SymfonyProfiler.php` * Replace backslashes with regular slashes in the URI --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sourceability/instrumentation/issues/24?shareId=XXXX-XXXX-XXXX-XXXX).
dev-cld
reviewed
Feb 18, 2025
dev-cld
left a comment
dev-cld
left a comment
There was a problem hiding this comment.
The modification in SymfonyProfiler.php seems sufficient, making the other two changes redundant.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Fix exception thrown using the Symfony profiler for Messenger workers
src/EventListener/MessengerProfilerListener.phpstr_replace('\\', '/', \get_class($event->getEnvelope()->getMessage()))src/Messenger/ProfilerMiddleware.phpstr_replace('\\', '/', \get_class($envelope->getMessage()))src/Profiler/SymfonyProfiler.phpFor more details, open the Copilot Workspace session.