Change Win32 ExitProcess to C func exit#3
Open
kawaii-ghost wants to merge 1 commit intosonictk:masterfrom
Open
Change Win32 ExitProcess to C func exit#3kawaii-ghost wants to merge 1 commit intosonictk:masterfrom
kawaii-ghost wants to merge 1 commit intosonictk:masterfrom
Conversation
Calling C runtime function must also terminated by C runtime itself (exit). Calling printf and then call ExitProcess without CRT function leads to hang because that does not let the C runtime terminate as gracefully. First argument also passed in `RCX`, `RAX` is used as return value. Did you mean `add rsp, 40; xor eax, eax; ret` ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling C runtime function must also terminated by C runtime itself (exit). Calling printf and then call ExitProcess without CRT function leads to hang because that does not let the C runtime terminate as gracefully.
First argument also passed in
RCX,RAXis used as return value. Did you meanadd rsp, 32; pop rbp; xor eax, eax; ret?