This repository was archived by the owner on Apr 13, 2022. It is now read-only.
Open
Conversation
Contributor
|
Related: seems that NSS never implemented it, so if that's true then there should be zero apps using it: nodeSolidServer/node-solid-server#962 Our wac-ldp module currently implements is using comunica. |
Contributor
Author
|
@michielbdejong Careful; v0.8 mentions “subset” of SPARQL. If you’re using all of Comunica, your subset if very large (if not complete), so a serious stability (DOS) risk exists (especially if single worker, which I believe it is) and even security (through the SERVICE keyword, but also JSON-LD context lookups). I would strongly advice to at least reduce the feature set if it is not removed altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not well specified; not used; dangerous DOS point.
Even better would be to just remove (#206)