This repository was archived by the owner on May 2, 2022. It is now read-only.
Prevent case that login search string is empty#9
Open
linonetwo wants to merge 5 commits intosolid-contrib:mainfrom
Open
Prevent case that login search string is empty#9linonetwo wants to merge 5 commits intosolid-contrib:mainfrom
linonetwo wants to merge 5 commits intosolid-contrib:mainfrom
Conversation
Might prevent a situation like solid-contrib#8
jaxoncreed
suggested changes
Jan 9, 2020
Contributor
jaxoncreed
left a comment
jaxoncreed
left a comment
There was a problem hiding this comment.
Could you provide a unit test for this?
jaxoncreed
suggested changes
Jan 9, 2020
Contributor
jaxoncreed
left a comment
jaxoncreed
left a comment
There was a problem hiding this comment.
Perhaps it would be better to error rather than creating an empty object.
Author
|
Ok, I simply throw an error instead. |
jaxoncreed
suggested changes
Jan 10, 2020
Contributor
jaxoncreed
left a comment
jaxoncreed
left a comment
There was a problem hiding this comment.
I would still be great to have a simple unit test for this.
TallTed
reviewed
Jan 10, 2020
Author
|
I'm going to add a test case, using |
Author
isn't easy to mock using jest-fetch mock, would you mind I refactor it to node-fetch? |
Contributor
|
I think that should be fine @linonetwo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might prevent a situation like #8